<html>
<head><meta charset="utf-8"><title>pending PRs · t-compiler/wg-parallel-rustc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/index.html">t-compiler/wg-parallel-rustc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html">pending PRs</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="159726640"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/159726640" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#159726640">(Mar 01 2019 at 16:18)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> I'll try to do some reviewing early next week!</p>



<a name="168351427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168351427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168351427">(Jun 17 2019 at 22:00)</a>:</h4>
<p>With my latest set of PRs , I think parallel rustc performs well enough to turn on.</p>
<p>The PRs are:</p>
<ul>
<li><a href="https://github.com/rust-lang/rust/pull/61873" target="_blank" title="https://github.com/rust-lang/rust/pull/61873">https://github.com/rust-lang/rust/pull/61873</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/61871" target="_blank" title="https://github.com/rust-lang/rust/pull/61871">https://github.com/rust-lang/rust/pull/61871</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/61845" target="_blank" title="https://github.com/rust-lang/rust/pull/61845">https://github.com/rust-lang/rust/pull/61845</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/61842" target="_blank" title="https://github.com/rust-lang/rust/pull/61842">https://github.com/rust-lang/rust/pull/61842</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/61779" target="_blank" title="https://github.com/rust-lang/rust/pull/61779">https://github.com/rust-lang/rust/pull/61779</a></li>
<li><a href="https://github.com/rust-lang/rust/pull/61392" target="_blank" title="https://github.com/rust-lang/rust/pull/61392">https://github.com/rust-lang/rust/pull/61392</a></li>
</ul>
<p>Here's a perf run with these PRs applied: <a href="https://perf.rust-lang.org/compare.html?start=f1dee7b53e8053afc315b500a514d7c013745acd&amp;end=4a5841a15e0c47e1c5f0c6a67145599db7499a7a&amp;stat=wall-time" target="_blank" title="https://perf.rust-lang.org/compare.html?start=f1dee7b53e8053afc315b500a514d7c013745acd&amp;end=4a5841a15e0c47e1c5f0c6a67145599db7499a7a&amp;stat=wall-time">https://perf.rust-lang.org/compare.html?start=f1dee7b53e8053afc315b500a514d7c013745acd&amp;end=4a5841a15e0c47e1c5f0c6a67145599db7499a7a&amp;stat=wall-time</a></p>
<p>Some of these PRs need a reviewer ;)</p>
<p>There one failing tests though (<code>ui/traits/cycle-cache-err-60010.rs</code>), which should be investigated. It recently broke, so <a href="https://github.com/rust-lang/rust/pull/61754" target="_blank" title="https://github.com/rust-lang/rust/pull/61754">https://github.com/rust-lang/rust/pull/61754</a> is probably a good suspect.</p>



<a name="168645419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168645419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168645419">(Jun 21 2019 at 00:12)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> awesome! I am talking to <span class="user-mention" data-user-id="116010">@Aaron Turon</span> about taking this up!</p>



<a name="168645420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168645420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168645420">(Jun 21 2019 at 00:12)</a>:</h4>
<p>What is that perf run comparing?</p>



<a name="168645489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168645489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168645489">(Jun 21 2019 at 00:14)</a>:</h4>
<p><code>[rust] parallel-compiler</code> on / off, both the with PRs applied</p>



<a name="168964186"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168964186" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168964186">(Jun 25 2019 at 18:32)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="116466">@Zoxc</span>! I'm returning from work leave and will be focused 100% on the compiler. My first orders are to get up to speed on the parallelization work you've been doing, which will include reviewing these PRs and working together on a plan for roll-out, blog announcements, etc. I'll also be writing up docs on how it works in the rustc guide. Looking forward to working with you to help get this out to the world!</p>



<a name="168964496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168964496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168964496">(Jun 25 2019 at 18:35)</a>:</h4>
<p>Also, <span class="user-mention" data-user-id="220056">@lwshang</span>, I was telling <span class="user-mention" data-user-id="116010">@Aaron Turon</span> that you were pretty keen to help out and that I've been leaving you hanging</p>



<a name="168964502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/168964502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#168964502">(Jun 25 2019 at 18:35)</a>:</h4>
<p>(For which I apologize :)</p>



<a name="170735510"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/170735510" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#170735510">(Jul 12 2019 at 16:22)</a>:</h4>
<p><span class="user-mention" data-user-id="116010">@Aaron Turon</span> Feel free to ask me questions about stuff if that will help</p>



<a name="170915822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/170915822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#170915822">(Jul 15 2019 at 17:52)</a>:</h4>
<p>thanks <span class="user-mention" data-user-id="116466">@Zoxc</span>, will do! i just got back from conference travel etc, so digging back into this stuff this week. my immediate priority is going  through the PR history to get  a  high  level  view (and collect things to audit for atomicity etc), once i've done that i'll dig into the pending PRs. thanks for your patience; i know this has been a long haul</p>



<a name="171286373"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/171286373" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#171286373">(Jul 19 2019 at 19:23)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="116466">@Zoxc</span>, just a quick update that unfortunately i had some major family stuff happen this week and haven't been able to do much here yet, but i'm working my way to it</p>



<a name="174552468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/174552468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#174552468">(Aug 30 2019 at 15:01)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> You're probably needed to review this PR if mw is too busy - <a href="https://github.com/rust-lang/rust/pull/62038" target="_blank" title="https://github.com/rust-lang/rust/pull/62038">https://github.com/rust-lang/rust/pull/62038</a></p>



<a name="174552611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/174552611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#174552611">(Aug 30 2019 at 15:02)</a>:</h4>
<p>hmm, ok. you can re-assign to me. I'll try to get on that.</p>



<a name="181041222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/pending%20PRs/near/181041222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/pending.20PRs.html#181041222">(Nov 18 2019 at 18:20)</a>:</h4>
<p>Maybe someone wants to revive <a href="https://github.com/rust-lang/rust/pull/61873" target="_blank" title="https://github.com/rust-lang/rust/pull/61873">https://github.com/rust-lang/rust/pull/61873</a> or <a href="https://github.com/rust-lang/rust/pull/61845" target="_blank" title="https://github.com/rust-lang/rust/pull/61845">https://github.com/rust-lang/rust/pull/61845</a> (has a bug)?</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>